Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)
Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
index 815f4789bdb43c568af74519440ebd8667a88413..fcc2ff73d1ed1283746a78644d32edd8f49e1023 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
@@ -14,6 +14,7 @@ import org.chromium.android_webview.AwContents.VisualStateCallback;
import org.chromium.android_webview.test.util.GraphicsTestUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
+import org.chromium.content_public.common.ContentUrlConstants;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
@@ -55,7 +56,8 @@ public class AwContentsRenderTest extends AwTestBase {
setBackgroundColorOnUiThread(Color.CYAN);
GraphicsTestUtils.pollForBackgroundColor(mAwContents, Color.CYAN);
- loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), "about:blank");
+ loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
+ ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);
assertEquals(Color.CYAN, GraphicsTestUtils.sampleBackgroundColorOnUiThread(mAwContents));
setBackgroundColorOnUiThread(Color.YELLOW);
@@ -86,7 +88,8 @@ public class AwContentsRenderTest extends AwTestBase {
});
int pictureCount = mContentsClient.getPictureListenerHelper().getCallCount();
- loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), "about:blank");
+ loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
+ ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);
mContentsClient.getPictureListenerHelper().waitForCallback(pictureCount, 1);
// Invalidation only, so picture should be null.
assertNull(mContentsClient.getPictureListenerHelper().getPicture());

Powered by Google App Engine
This is Rietveld 408576698