Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
Review-Url: https://codereview.chromium.org/2773813002
Cr-Commit-Position: refs/heads/master@{#459244}
Committed: https://chromium.googlesource.com/chromium/src/+/2a53e839bbe97b3936efad635e8feed3551cf545

[Mark Mentovai, 2017-03-23 19:34:18]

mark@chromium.org changed reviewers:
+ scottmg@chromium.org

[Mark Mentovai, 2017-03-23 19:34:19]

It’s been a busy week and a half.

There’s nothing pressing here except for maybe b10d9118dea4, but I didn’t want
to float too far from the ship.

[Mark Mentovai, 2017-03-23 19:34:32]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:35:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-23 20:27:34]

lgtm

https://codereview.chromium.org/2773813002/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/util.gyp (right):

https://codereview.chromium.org/2773813002/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/util.gyp:140: 'posix/process_info_linux.cc',
I guess adding this to the GN didn't get it excluded? (I don't know how broken
the gn are on Linux.)

[Mark Mentovai, 2017-03-23 20:30:36]

https://codereview.chromium.org/2773813002/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/util.gyp (right):

https://codereview.chromium.org/2773813002/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/util.gyp:140: 'posix/process_info_linux.cc',
scottmg wrote:
> I guess adding this to the GN didn't get it excluded? (I don't know how broken
> the gn are on Linux.)

We have zero GN coverage for Linux/Android or tests right now. We’ll have to
deal with that eventually, but since all we can really build in Crashpad for
Linux/Android right now are tests, and we don’t have any coverage for Crashpad
tests in Chrome’s GN build files, I don’t even have a good way to validate any
Linux/Android changes I might make there.

[commit-bot: I haz the power, 2017-03-23 20:40:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:40:12]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2017-03-23 20:50:54]

Description was changed from

==========
Update Crashpad to f8ef834ef5dd3f2863c2ac25ff707bc7bfbcd1f3

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
==========

to

==========
Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
==========

[Mark Mentovai, 2017-03-23 20:53:16]

Description was changed from

==========
Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
==========

to

==========
Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
==========

[Mark Mentovai, 2017-03-23 20:53:24]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2017-03-23 20:53:25]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2773813002/#ps20001
(title: "Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98")

[commit-bot: I haz the power, 2017-03-23 20:53:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:06:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490302404880550,
"parent_rev": "753c5e6239a50d12842c7594898c93210f185ee1", "commit_rev":
"2a53e839bbe97b3936efad635e8feed3551cf545"}

[commit-bot: I haz the power, 2017-03-23 22:07:36]

Description was changed from

==========
Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
==========

to

==========
Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
             StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
             ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
             Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
             (compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
             collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
             ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
             argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
             names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
             with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
             development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
             crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision

BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890

Review-Url: https://codereview.chromium.org/2773813002
Cr-Commit-Position: refs/heads/master@{#459244}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a53e839bbe97b3936efad635e8f...
==========

[commit-bot: I haz the power, 2017-03-23 22:07:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a53e839bbe97b3936efad635e8f...