third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_file_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

index 8635190b3b8669545b68bc9ef7d335b986e18006..613c5dd1507af2492b6ab84f42e953d1c3884869 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc

@@ -102,7 +102,7 @@ TEST(MinidumpExceptionWriter, Minimal) {

InitializeMinidumpContextX86(context_x86_writer->context(), kSeed);

exception_writer->SetContext(std::move(context_x86_writer));

- minidump_file_writer.AddStream(std::move(exception_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -161,7 +161,7 @@ TEST(MinidumpExceptionWriter, Standard) {

exception_information.push_back(kExceptionInformation2);

exception_writer->SetExceptionInformation(exception_information);

- minidump_file_writer.AddStream(std::move(exception_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -234,7 +234,7 @@ TEST(MinidumpExceptionWriter, InitializeFromSnapshot) {

exception_writer->InitializeFromSnapshot(&exception_snapshot, thread_id_map);

MinidumpFileWriter minidump_file_writer;

- minidump_file_writer.AddStream(std::move(exception_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -256,7 +256,7 @@ TEST(MinidumpExceptionWriterDeathTest, NoContext) {

MinidumpFileWriter minidump_file_writer;

auto exception_writer = base::WrapUnique(new MinidumpExceptionWriter());

- minidump_file_writer.AddStream(std::move(exception_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(exception_writer)));

StringFile string_file;

ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),