third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc

index 982da7138f57aac5f3607ce47d56ae1ca154f49f..db4cae5baf3f47faae890c210828fe6c91990090 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc

@@ -59,7 +59,7 @@ void GetHandleDataStream(

TEST(MinidumpHandleDataWriter, Empty) {

MinidumpFileWriter minidump_file_writer;

auto handle_data_writer = base::WrapUnique(new MinidumpHandleDataWriter());

- minidump_file_writer.AddStream(std::move(handle_data_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(handle_data_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -92,7 +92,7 @@ TEST(MinidumpHandleDataWriter, OneHandle) {

handle_data_writer->InitializeFromSnapshot(snapshot);

- minidump_file_writer.AddStream(std::move(handle_data_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(handle_data_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -150,7 +150,7 @@ TEST(MinidumpHandleDataWriter, RepeatedTypeName) {

handle_data_writer->InitializeFromSnapshot(snapshot);

- minidump_file_writer.AddStream(std::move(handle_data_writer));

+ ASSERT_TRUE(minidump_file_writer.AddStream(std::move(handle_data_writer)));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));