third_party/crashpad/crashpad/util/win/exception_handler_server.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/win/exception_handler_server.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/util/win/exception_handler_server.cc

diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc

index 70955c825b73afa1e56840fa0d23231d055f5519..fdc159c0bf98c6c85790136db18bbc8e317f4aaa 100644

--- a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc

+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc

@@ -396,7 +396,8 @@ bool ExceptionHandlerServer::ServiceClientConnection(

const internal::PipeServiceContext& service_context) {

ClientToServerMessage message;

- if (!LoggingReadFile(service_context.pipe(), &message, sizeof(message)))

+ if (!LoggingReadFileExactly(

+ service_context.pipe(), &message, sizeof(message)))

return false;

switch (message.type) {