third_party/crashpad/crashpad/handler/win/crash_other_program.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/handler/win/crash_other_program.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/crashpad/crashpad/handler/win/crash_other_program.cc

diff --git a/third_party/crashpad/crashpad/handler/win/crash_other_program.cc b/third_party/crashpad/crashpad/handler/win/crash_other_program.cc

index d191aac01ed0e1b9df64bdbd681cb9b51d1e9420..012b4ba3cc3a8bc3c5d719e8c14fb1c075fad080 100644

--- a/third_party/crashpad/crashpad/handler/win/crash_other_program.cc

+++ b/third_party/crashpad/crashpad/handler/win/crash_other_program.cc

@@ -90,7 +90,8 @@ int CrashOtherProgram(int argc, wchar_t* argv[]) {

// Wait until it's ready.

char c;

- if (!LoggingReadFile(child.stdout_read_handle(), &c, sizeof(c)) || c != ' ') {

+ if (!LoggingReadFileExactly(child.stdout_read_handle(), &c, sizeof(c)) ||

+ c != ' ') {

LOG(ERROR) << "failed child communication";

return EXIT_FAILURE;

}