Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/crashpad/crashpad/client/settings.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)
Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/settings.cc
diff --git a/third_party/crashpad/crashpad/client/settings.cc b/third_party/crashpad/crashpad/client/settings.cc
index 7757ecb01c455754dbc271cbdb6cd4fd4cf95f55..15d16f2e092887da98ec7b7d9eded1e81e5708d2 100644
--- a/third_party/crashpad/crashpad/client/settings.cc
+++ b/third_party/crashpad/crashpad/client/settings.cc
@@ -246,13 +246,10 @@ bool Settings::ReadSettings(FileHandle handle,
if (LoggingSeekFile(handle, 0, SEEK_SET) != 0)
return false;
- bool read_result;
- if (log_read_error) {
- read_result = LoggingReadFile(handle, out_data, sizeof(*out_data));
- } else {
- read_result =
- ReadFile(handle, out_data, sizeof(*out_data)) == sizeof(*out_data);
- }
+ bool read_result =
+ log_read_error
+ ? LoggingReadFileExactly(handle, out_data, sizeof(*out_data))
+ : ReadFileExactly(handle, out_data, sizeof(*out_data));
if (!read_result)
return false;
« no previous file with comments | « third_party/crashpad/crashpad/client/crash_report_database_win.cc ('k') | third_party/crashpad/crashpad/compat/android/elf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698