third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/util/win/exception_handler_server.cc ('k') | third_party/crashpad/crashpad/util/win/process_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

index e94b91d5da6df88fa5f0cb7d232d5966bc353f99..e9f865bef9c1bb595d1bf1dee3054c606e8a7e3c 100644

--- a/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

@@ -143,10 +143,11 @@ TEST_F(ExceptionHandlerServerTest, StopWhileConnected) {

std::wstring ReadWString(FileHandle handle) {

size_t length = 0;

- EXPECT_TRUE(LoggingReadFile(handle, &length, sizeof(length)));

+ EXPECT_TRUE(LoggingReadFileExactly(handle, &length, sizeof(length)));

std::wstring str(length, L'\0');

if (length > 0) {

- EXPECT_TRUE(LoggingReadFile(handle, &str[0], length * sizeof(str[0])));

+ EXPECT_TRUE(

+ LoggingReadFileExactly(handle, &str[0], length * sizeof(str[0])));

}

return str;

}