third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.cc ('k') | third_party/crashpad/crashpad/snapshot/cpu_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc

diff --git a/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc b/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc

index 30e880f321d54208a2d1410c59f176d2a5a3b89d..ee028683c97bdfbf9039221e7e9274e1e87e3797 100644

--- a/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc

+++ b/third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc

@@ -28,7 +28,7 @@ class ModuleAnnotationsMultiprocessTest final : public WinMultiprocess {

void WinMultiprocessParent() override {

// Read the child executable module.

HMODULE module = nullptr;

- CheckedReadFile(ReadPipeHandle(), &module, sizeof(module));

+ CheckedReadFileExactly(ReadPipeHandle(), &module, sizeof(module));

// Reopen the child process with necessary access.

HANDLE process_handle =

@@ -70,7 +70,7 @@ class ModuleAnnotationsMultiprocessTest final : public WinMultiprocess {

// Wait until a signal from the parent process to terminate.

char c;

- CheckedReadFile(ReadPipeHandle(), &c, sizeof(c));

+ CheckedReadFileExactly(ReadPipeHandle(), &c, sizeof(c));

}

};