Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 61 matching lines @@
 
   *memory_list = MinidumpWritableAtLocationDescriptor<MINIDUMP_MEMORY_LIST>(
       file_contents, directory[directory_index].Location);
   ASSERT_TRUE(memory_list);
 }
 
 TEST(MinidumpMemoryWriter, EmptyMemoryList) {
   MinidumpFileWriter minidump_file_writer;
   auto memory_list_writer = base::WrapUnique(new MinidumpMemoryListWriter());
 
-  minidump_file_writer.AddStream(std::move(memory_list_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(memory_list_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   ASSERT_EQ(sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MEMORY_LIST),
             string_file.string().size());
 
   const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetMemoryListStream(string_file.string(), &memory_list, 1));
 
   EXPECT_EQ(0u, memory_list->NumberOfMemoryRanges);
 }
 
 TEST(MinidumpMemoryWriter, OneMemoryRegion) {
   MinidumpFileWriter minidump_file_writer;
   auto memory_list_writer = base::WrapUnique(new MinidumpMemoryListWriter());
 
   const uint64_t kBaseAddress = 0xfedcba9876543210;
   const uint64_t kSize = 0x1000;
   const uint8_t kValue = 'm';
 
   auto memory_writer = base::WrapUnique(
       new TestMinidumpMemoryWriter(kBaseAddress, kSize, kValue));
   memory_list_writer->AddMemory(std::move(memory_writer));
 
-  minidump_file_writer.AddStream(std::move(memory_list_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(memory_list_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetMemoryListStream(string_file.string(), &memory_list, 1));
 
   MINIDUMP_MEMORY_DESCRIPTOR expected;
   expected.StartOfMemoryRange = kBaseAddress;
@@ skipping 20 matching lines @@
   const uint64_t kSize1 = 0x0200;
   const uint8_t kValue1 = '!';
 
   auto memory_writer_0 = base::WrapUnique(
       new TestMinidumpMemoryWriter(kBaseAddress0, kSize0, kValue0));
   memory_list_writer->AddMemory(std::move(memory_writer_0));
   auto memory_writer_1 = base::WrapUnique(
       new TestMinidumpMemoryWriter(kBaseAddress1, kSize1, kValue1));
   memory_list_writer->AddMemory(std::move(memory_writer_1));
 
-  minidump_file_writer.AddStream(std::move(memory_list_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(memory_list_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetMemoryListStream(string_file.string(), &memory_list, 1));
 
   EXPECT_EQ(2u, memory_list->NumberOfMemoryRanges);
 
@@ skipping 78 matching lines @@
 
   const uint64_t kBaseAddress0 = 0x1000;
   const size_t kSize0 = 0x0400;
   const uint8_t kValue0 = '1';
   auto test_memory_stream =
       base::WrapUnique(new TestMemoryStream(kBaseAddress0, kSize0, kValue0));
 
   auto memory_list_writer = base::WrapUnique(new MinidumpMemoryListWriter());
   memory_list_writer->AddExtraMemory(test_memory_stream->memory());
 
-  minidump_file_writer.AddStream(std::move(test_memory_stream));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(test_memory_stream)));
 
   const uint64_t kBaseAddress1 = 0x2000;
   const size_t kSize1 = 0x0400;
   const uint8_t kValue1 = 'm';
 
   auto memory_writer = base::WrapUnique(
       new TestMinidumpMemoryWriter(kBaseAddress1, kSize1, kValue1));
   memory_list_writer->AddMemory(std::move(memory_writer));
 
-  minidump_file_writer.AddStream(std::move(memory_list_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(memory_list_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetMemoryListStream(string_file.string(), &memory_list, 2));
 
   EXPECT_EQ(2u, memory_list->NumberOfMemoryRanges);
 
@@ skipping 57 matching lines @@
         expect_memory_descriptors[index].StartOfMemoryRange);
     memory_snapshot->SetSize(expect_memory_descriptors[index].Memory.DataSize);
     memory_snapshot->SetValue(values[index]);
     memory_snapshots.push_back(memory_snapshot);
   }
 
   auto memory_list_writer = base::WrapUnique(new MinidumpMemoryListWriter());
   memory_list_writer->AddFromSnapshot(memory_snapshots);
 
   MinidumpFileWriter minidump_file_writer;
-  minidump_file_writer.AddStream(std::move(memory_list_writer));
+  ASSERT_TRUE(minidump_file_writer.AddStream(std::move(memory_list_writer)));
 
   StringFile string_file;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));
 
   const MINIDUMP_MEMORY_LIST* memory_list = nullptr;
   ASSERT_NO_FATAL_FAILURE(
       GetMemoryListStream(string_file.string(), &memory_list, 1));
 
   ASSERT_EQ(3u, memory_list->NumberOfMemoryRanges);
 
   for (size_t index = 0; index < memory_list->NumberOfMemoryRanges; ++index) {
     SCOPED_TRACE(base::StringPrintf("index %" PRIuS, index));
     ExpectMinidumpMemoryDescriptorAndContents(
         &expect_memory_descriptors[index],
         &memory_list->MemoryRanges[index],
         string_file.string(),
         values[index],
         index == memory_list->NumberOfMemoryRanges - 1);
   }
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad