third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc - Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)

Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac.cc ('k') | third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

diff --git a/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc b/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

index 7a94eb2c2cfb324c0994e42dc372ea40be62e250..50e646aec946c3672bf4d7fcefb52a47aea7b023 100644

--- a/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

+++ b/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc

@@ -245,7 +245,7 @@ class TestMachOImageAnnotationsReader final

// Wait for the child process to indicate that it’s done setting up its

// annotations via the CrashpadInfo interface.

char c;

- CheckedReadFile(ReadPipeHandle(), &c, sizeof(c));

+ CheckedReadFileExactly(ReadPipeHandle(), &c, sizeof(c));

// Verify the “simple map” annotations set via the CrashpadInfo interface.

const std::vector<ProcessReader::Module>& modules =

@@ -333,7 +333,7 @@ class TestMachOImageAnnotationsReader final

CheckedWriteFile(WritePipeHandle(), &c, sizeof(c));

// Wait for the parent to indicate that it’s safe to crash.

- CheckedReadFile(ReadPipeHandle(), &c, sizeof(c));

+ CheckedReadFileExactly(ReadPipeHandle(), &c, sizeof(c));

// Direct an exception message to the exception server running in the

// parent.