Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/crashpad/crashpad/build/gyp_crashpad.py

Issue 2773813002: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 (Closed)
Patch Set: Update Crashpad to 8e37886d418dd042c3c7bfadac99214739ee4d98 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/build/gyp_crashpad.py
diff --git a/third_party/crashpad/crashpad/build/gyp_crashpad.py b/third_party/crashpad/crashpad/build/gyp_crashpad.py
index fe9da84021b1b970a1e30cb9f6bfddf497b79625..dd5fa69ca3bb187dfa85b363a174cfa35f400c8b 100755
--- a/third_party/crashpad/crashpad/build/gyp_crashpad.py
+++ b/third_party/crashpad/crashpad/build/gyp_crashpad.py
@@ -75,11 +75,24 @@ def main(args):
return result
if sys.platform == 'win32':
- # Also generate the x86 build.
- result = gyp.main(args + ['-D', 'target_arch=ia32', '-G', 'config=Debug'])
- if result != 0:
- return result
- result = gyp.main(args + ['-D', 'target_arch=ia32', '-G', 'config=Release'])
+ # Check to make sure that no target_arch was specified. target_arch may be
+ # set during a cross build, such as a cross build for Android.
+ has_target_arch = False
+ for arg_index in xrange(0, len(args)):
+ arg = args[arg_index]
+ if (arg.startswith('-Dtarget_arch=') or
+ (arg == '-D' and arg_index + 1 < len(args) and
+ args[arg_index + 1].startswith('target_arch='))):
+ has_target_arch = True
+ break
+
+ if not has_target_arch:
+ # Also generate the x86 build.
+ result = gyp.main(args + ['-D', 'target_arch=ia32', '-G', 'config=Debug'])
+ if result != 0:
+ return result
+ result = gyp.main(
+ args + ['-D', 'target_arch=ia32', '-G', 'config=Release'])
return result
« no previous file with comments | « third_party/crashpad/crashpad/README.md ('k') | third_party/crashpad/crashpad/build/gyp_crashpad_android.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698