Fix duplicate test names in WebAudio tests

Fix duplicate test names in WebAudio tests

Testharness prints errors about duplicate test names.  Fix up these
duplicate names.  For the most part, the minimum change was done to
remove the duplicate test names.  However, a few tests did a little
bit more to make the resulting output "nice" because the changes were
simple.

To verify these, apply the patch from crrev.com/2766823003 and run
tests locally.  No tests fail.  Without the patch, you can't tell from
run-webkit-tests if anything is still broken.

BUG=703849
TEST=

Review-Url: https://codereview.chromium.org/2768983002
Cr-Commit-Position: refs/heads/master@{#458918}
Committed: https://chromium.googlesource.com/chromium/src/+/1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85

[Raymond Toy, 2017-03-22 21:56:36]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org, qyearsley@chromium.org

[Raymond Toy, 2017-03-22 21:56:36]

PTAL.

FYI: qyearsley

[hongchan, 2017-03-22 22:09:42]

By adding more text in the name (e.g. prefix + ...), many changes makes the line
overflow over column 80.

If you can wrap all the changes (and changes only), this CL is fine by me.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
(right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html:208:
let prefix = "Length " + config.curveLength + ", duration " +
config.curveDuration;
Let's wrap at 80.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html:245:
let prefix = "Curve length " + config.curveLength + ", duration " +
config.curveDuration;
Ditto.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
(right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html:173: let
prefix = "Sample rate " + sampleRate + ": Delayed cosine oscillator";
Wrap at 80.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html
(right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:117:
success = Should('Set panner.panningModel = "' + panningModels[i] + '"',
function () {
Wrap at 80.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:129:
success = Should("panner.panningModel after invalid setter",
panner.panningModel)
Ditto.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
(right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:61:
Should(prefix + ': Transition found between sample #' + start + ' and #' + end,
Wrap at 80.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html:151:
Should(options.message + ': Channel #0',
actual.left).notGlitch(GLITCH_THRESHOLD);
Wrap at 80. Ditto for the next few lines.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html
(right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html:18:
StereoPannerTest.create({ numberOfInputChannels: 1, prefix: "Mono: "
}).run(done);
Wrap at 80.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html:22:
StereoPannerTest.create({ numberOfInputChannels: 2, prefix: "Stereo: "
}).run(done);
Ditto.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html (right):

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html:52: success =
Should("node1 = new AnalyserNode(c)", function () {
Wrap at 80 for all changes.

https://codereview.chromium.org/2768983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html:92: success =
Should("node1 = new AnalyserNode(c, " + JSON.stringify(options) + ")", function
() {
Ditto.

[hongchan, 2017-03-22 22:25:14]

lgtm

lgtm

[Raymond Toy, 2017-03-22 22:29:23]

On 2017/03/22 22:25:14, hongchan wrote:
> lgtm
> 
> lgtm

And to be clear, we discussed offline not to indent in this CL.  We'll get to
that later.

[Raymond Toy, 2017-03-22 22:29:39]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:30:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:05:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490221779462520, "parent_rev":
"dfc3e7204e434185cbaa0d6cb48ae0b37481f007", "commit_rev":
"1c2910f5ef29e52e1d4f5bc139e8515d8bcf1a85"}

[commit-bot: I haz the power, 2017-03-22 23:06:16]

Description was changed from

==========
Fix duplicate test names in WebAudio tests

Testharness prints errors about duplicate test names.  Fix up these
duplicate names.  For the most part, the minimum change was done to
remove the duplicate test names.  However, a few tests did a little
bit more to make the resulting output "nice" because the changes were
simple.

To verify these, apply the patch from crrev.com/2766823003 and run
tests locally.  No tests fail.  Without the patch, you can't tell from
run-webkit-tests if anything is still broken.

BUG=703849
TEST=
==========

to

==========
Fix duplicate test names in WebAudio tests

Testharness prints errors about duplicate test names.  Fix up these
duplicate names.  For the most part, the minimum change was done to
remove the duplicate test names.  However, a few tests did a little
bit more to make the resulting output "nice" because the changes were
simple.

To verify these, apply the patch from crrev.com/2766823003 and run
tests locally.  No tests fail.  Without the patch, you can't tell from
run-webkit-tests if anything is still broken.

BUG=703849
TEST=

Review-Url: https://codereview.chromium.org/2768983002
Cr-Commit-Position: refs/heads/master@{#458918}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c2910f5ef29e52e1d4f5bc139e8...
==========

[commit-bot: I haz the power, 2017-03-22 23:06:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c2910f5ef29e52e1d4f5bc139e8...

[qyearsley, 2017-03-22 23:07:52]

lgtm