Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/gain.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html b/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
index b394fee792d02e824c99891de16296a4eca1ac9c..022476ce55ff663fc78b209c502cf42ea0a15f28 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/gain.html
@@ -48,21 +48,21 @@
var node;
var success = true;
- success = Should("node = new GainNode(context)", function () {
+ success = Should("node0 = new GainNode(context)", function () {
node = new GainNode(context);
}).notThrow();
- success = Should("node instanceof GainNode",
+ success = Should("node0 instanceof GainNode",
node instanceof GainNode)
.beEqualTo(true) && success;
- success = Should("node.gain.value", node.gain.value)
+ success = Should("node0.gain.value", node.gain.value)
.beEqualTo(1) && success;
- success = Should("node.channelCount", node.channelCount)
+ success = Should("node0.channelCount", node.channelCount)
.beEqualTo(2) && success;
- success = Should("node.channelCountMode", node.channelCountMode)
+ success = Should("node0.channelCountMode", node.channelCountMode)
.beEqualTo("max") && success;
- success = Should("node.channelInterpretation", node.channelInterpretation)
+ success = Should("node0.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
Should("new GainNode(context)", success)
@@ -85,21 +85,21 @@
gain: -2,
};
- success = Should("node = new GainNode(c, " + JSON.stringify(options) + ")", function () {
+ success = Should("node1 = new GainNode(c, " + JSON.stringify(options) + ")", function () {
node = new GainNode(context, options);
}).notThrow();
- success = Should("node instanceof GainNode",
+ success = Should("node1 instanceof GainNode",
node instanceof GainNode)
.beEqualTo(true) && success;
- success = Should("node.gain.value", node.gain.value)
+ success = Should("node1.gain.value", node.gain.value)
.beEqualTo(options.gain) && success;
- success = Should("node.channelCount", node.channelCount)
+ success = Should("node1.channelCount", node.channelCount)
.beEqualTo(2) && success;
- success = Should("node.channelCountMode", node.channelCountMode)
+ success = Should("node1.channelCountMode", node.channelCountMode)
.beEqualTo("max") && success;
- success = Should("node.channelInterpretation", node.channelInterpretation)
+ success = Should("node1.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
Should("new GainNode() with options", success)

Powered by Google App Engine
This is Rietveld 408576698