third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html - Issue 2768983002: Fix duplicate test names in WebAudio tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html ('K') | « third_party/WebKit/LayoutTests/webaudio/Panner/panner-distance-clamping.html ('k') | third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html » ('j') | third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html b/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

index 77b97495838e18de7de3af6bc7eeec1b8a5f62d7..8c936c58f098664879a558d906353e81a22e8140 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

@@ -114,7 +114,7 @@

var success = true;

for (var i = 0; i < panningModels.length; ++i) {

- success = Should('panner.panningModel = "' + panningModels[i] + '"', function () {

+ success = Should('Set panner.panningModel = "' + panningModels[i] + '"', function () {

hongchan 2017/03/22 22:09:42 Wrap at 80.

panner.panningModel = panningModels[i];

}).notThrow() && success;

@@ -126,7 +126,7 @@

panner.panningModel = "invalid";

}).notThrow() && success;

- success = Should("panner.panningModel", panner.panningModel)

+ success = Should("panner.panningModel after invalid setter", panner.panningModel)

hongchan 2017/03/22 22:09:42 Ditto.

.beEqualTo("HRTF") && success;

// Check that numerical values are no longer supported. We shouldn't throw and the value