Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html b/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
index 9d32633d9d0db1f6f0117d3e649a058afb6c02aa..558cfb339c8bb6da28178d940f2d27200f28fea7 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
@@ -49,19 +49,19 @@
var node;
var success = true;
- success = Should("node = new AnalyserNode(c)", function () {
+ success = Should("node1 = new AnalyserNode(c)", function () {
hongchan 2017/03/22 22:09:42 Wrap at 80 for all changes.
node = new AnalyserNode(context);
}).notThrow();
- success = Should("node instanceof AnalyserNode", node instanceof AnalyserNode)
+ success = Should("node0 instanceof AnalyserNode", node instanceof AnalyserNode)
.beEqualTo(true) && success;
- success = Should("node.fftSize", node.fftSize).beEqualTo(2048) && success;
- success = Should("node.frequencyBinCount",
+ success = Should("node0.fftSize", node.fftSize).beEqualTo(2048) && success;
+ success = Should("node0.frequencyBinCount",
node.frequencyBinCount).beEqualTo(1024) && success;
- success = Should("node.minDecibels", node.minDecibels).beEqualTo(-100) && success;
- success = Should("node.maxDecibels", node.maxDecibels).beEqualTo(-30) && success;
+ success = Should("node0.minDecibels", node.minDecibels).beEqualTo(-100) && success;
+ success = Should("node0.maxDecibels", node.maxDecibels).beEqualTo(-30) && success;
// All AudioParams are stored as single precision values. Compare
// against the single-precision float value.
- success = Should("node.smoothingTimeConstant", node.smoothingTimeConstant)
+ success = Should("node0.smoothingTimeConstant", node.smoothingTimeConstant)
.beEqualTo(Math.fround(0.8)) && success;
Should("new AnalyserNode(c)", success)
@@ -89,19 +89,19 @@
var node;
var success = true;
- success = Should("node = new AnalyserNode(c, " + JSON.stringify(options) + ")", function () {
+ success = Should("node1 = new AnalyserNode(c, " + JSON.stringify(options) + ")", function () {
hongchan 2017/03/22 22:09:42 Ditto.
node = new AnalyserNode(context, options);
}).notThrow();
- success = Should("node instanceof AnalyserNode", node instanceof AnalyserNode)
+ success = Should("node1 instanceof AnalyserNode", node instanceof AnalyserNode)
.beEqualTo(true) && success;
- success = Should("node.fftSize", node.fftSize)
+ success = Should("node1.fftSize", node.fftSize)
.beEqualTo(options.fftSize) && success;
- success = Should("node.maxDecibels", node.maxDecibels)
+ success = Should("node1.maxDecibels", node.maxDecibels)
.beEqualTo(options.maxDecibels) && success;
- success = Should("node.minDecibels", node.minDecibels)
+ success = Should("node1.minDecibels", node.minDecibels)
.beEqualTo(options.minDecibels) && success;
- success = Should("node.smoothingTimeConstant", node.smoothingTimeConstant)
+ success = Should("node1.smoothingTimeConstant", node.smoothingTimeConstant)
.beEqualTo(options.smoothingTimeConstant) && success;
Should("new AnalyserNode() with options", success)

Powered by Google App Engine
This is Rietveld 408576698