Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/constructor/waveshaper.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html ('K') | « third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html ('k') | third_party/WebKit/LayoutTests/webaudio/mixing.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!doctype html> 1 <!doctype html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Test Constructor: WaveShaper</title> 4 <title>Test Constructor: WaveShaper</title>
5 <script src="../../resources/testharness.js"></script> 5 <script src="../../resources/testharness.js"></script>
6 <script src="../../resources/testharnessreport.js"></script> 6 <script src="../../resources/testharnessreport.js"></script>
7 <script src="../resources/audit-util.js"></script> 7 <script src="../resources/audit-util.js"></script>
8 <script src="../resources/audio-testing.js"></script> 8 <script src="../resources/audio-testing.js"></script>
9 <script src="audionodeoptions.js"></script> 9 <script src="audionodeoptions.js"></script>
10 </head> 10 </head>
(...skipping 27 matching lines...) Expand all
38 success = Should("Invalid constructors", success) 38 success = Should("Invalid constructors", success)
39 .summarize( 39 .summarize(
40 "correctly threw errors", 40 "correctly threw errors",
41 "did not throw errors in all cases"); 41 "did not throw errors in all cases");
42 taskDone(); 42 taskDone();
43 }); 43 });
44 44
45 audit.defineTask("valid default construction", function (taskDone) { 45 audit.defineTask("valid default construction", function (taskDone) {
46 var node; 46 var node;
47 47
48 success = Should("node = new WaveShaperNode(context)", function () { 48 success = Should("node0 = new WaveShaperNode(context)", function () {
49 node = new WaveShaperNode(context); 49 node = new WaveShaperNode(context);
50 }).notThrow(); 50 }).notThrow();
51 success = Should("node.curve", node.curve).beEqualTo(null) && success; 51 success = Should("node0.curve", node.curve).beEqualTo(null) && success;
52 success = Should("node.oversample", node.oversample).beEqualTo("none") & & success; 52 success = Should("node0.oversample", node.oversample).beEqualTo("none") && success;
53 53
54 success = Should("node.channelCount", node.channelCount) 54 success = Should("node0.channelCount", node.channelCount)
55 .beEqualTo(2) && success; 55 .beEqualTo(2) && success;
56 success = Should("node.channelCountMode", node.channelCountMode) 56 success = Should("node0.channelCountMode", node.channelCountMode)
57 .beEqualTo("max") && success; 57 .beEqualTo("max") && success;
58 success = Should("node.channelInterpretation", node.channelInterpretatio n) 58 success = Should("node0.channelInterpretation", node.channelInterpretati on)
59 .beEqualTo("speakers") && success; 59 .beEqualTo("speakers") && success;
60 60
61 Should("new WaveShaperNode(context)", success) 61 Should("new WaveShaperNode(context)", success)
62 .summarize( 62 .summarize(
63 "constructed node with correct attributes", 63 "constructed node with correct attributes",
64 "did not construct correct node correctly") 64 "did not construct correct node correctly")
65 65
66 taskDone(); 66 taskDone();
67 }); 67 });
68 68
69 audit.defineTask("test AudioNodeOptions", function (taskDone) { 69 audit.defineTask("test AudioNodeOptions", function (taskDone) {
70 testAudioNodeOptions(context, "WaveShaperNode"); 70 testAudioNodeOptions(context, "WaveShaperNode");
71 taskDone(); 71 taskDone();
72 }); 72 });
73 73
74 audit.defineTask("valid non-default", function (taskDone) { 74 audit.defineTask("valid non-default", function (taskDone) {
75 // Construct an WaveShaperNode with options 75 // Construct an WaveShaperNode with options
76 var options = { 76 var options = {
77 curve: Float32Array.from([1,2,3]), 77 curve: Float32Array.from([1,2,3]),
78 oversample: "4x" 78 oversample: "4x"
79 }; 79 };
80 var node; 80 var node;
81 81
82 var message = "node = new WaveShaperNode(, " + JSON.stringify(options) + ")"; 82 var message = "node1 = new WaveShaperNode(, " + JSON.stringify(options) + ")";
83 success = Should(message, function () { 83 success = Should(message, function () {
84 node = new WaveShaperNode(context, options); 84 node = new WaveShaperNode(context, options);
85 }).notThrow(); 85 }).notThrow();
86 success = Should("node.curve", node.curve) 86 success = Should("node1.curve", node.curve)
87 .beEqualToArray(options.curve) && success; 87 .beEqualToArray(options.curve) && success;
88 success = Should("node.oversample", node.oversample) 88 success = Should("node1.oversample", node.oversample)
89 .beEqualTo(options.oversample) && success; 89 .beEqualTo(options.oversample) && success;
90 90
91 Should("new WaveShaper() with options", success) 91 Should("new WaveShaper() with options", success)
92 .summarize( 92 .summarize(
93 "constructed with correct attributes", 93 "constructed with correct attributes",
94 "was not constructed correctly"); 94 "was not constructed correctly");
95 95
96 taskDone(); 96 taskDone();
97 }); 97 });
98 98
99 audit.runTasks(); 99 audit.runTasks();
100 </script> 100 </script>
101 </body> 101 </body>
102 </html> 102 </html>
OLDNEW
« third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html ('K') | « third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html ('k') | third_party/WebKit/LayoutTests/webaudio/mixing.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698