Chromium Code Reviews Chromium Code Reviews
Issue 2768983002:
Fix duplicate test names in WebAudio tests (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 | 3 |
| 4 <head> | 4 <head> |
| 5 <script src="../../resources/testharness.js"></script> | 5 <script src="../../resources/testharness.js"></script> |
| 6 <script src="../../resources/testharnessreport.js"></script> | 6 <script src="../../resources/testharnessreport.js"></script> |
| 7 <script src="../resources/audit-util.js"></script> | 7 <script src="../resources/audit-util.js"></script> |
| 8 <script src="../resources/audio-testing.js"></script> | 8 <script src="../resources/audio-testing.js"></script> |
| 9 </head> | 9 </head> |
| 10 | 10 |
| (...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 107 .summarize("passed", "failed"); | 107 .summarize("passed", "failed"); |
| 108 done(); | 108 done(); |
| 109 }); | 109 }); |
| 110 | 110 |
| 111 audit.defineTask("panning models", function (done) { | 111 audit.defineTask("panning models", function (done) { |
| 112 // Check that the .panningModel attribute can be set to all legal values . | 112 // Check that the .panningModel attribute can be set to all legal values . |
| 113 var panningModels = ["equalpower", "HRTF"]; | 113 var panningModels = ["equalpower", "HRTF"]; |
| 114 | 114 |
| 115 var success = true; | 115 var success = true; |
| 116 for (var i = 0; i < panningModels.length; ++i) { | 116 for (var i = 0; i < panningModels.length; ++i) { |
| 117 success = Should('panner.panningModel = "' + panningModels[i] + '"', f unction () { | 117 success = Should('Set panner.panningModel = "' + panningModels[i] + '" ', function () { |
|
hongchan
2017/03/22 22:09:42
Wrap at 80.
| |
| 118 panner.panningModel = panningModels[i]; | 118 panner.panningModel = panningModels[i]; |
| 119 }).notThrow() && success; | 119 }).notThrow() && success; |
| 120 | 120 |
| 121 success = Should('panner.panningModel = "' + panningModels[i] + '"', p anner.panningModel) | 121 success = Should('panner.panningModel = "' + panningModels[i] + '"', p anner.panningModel) |
| 122 .beEqualTo(panningModels[i]) && success; | 122 .beEqualTo(panningModels[i]) && success; |
| 123 } | 123 } |
| 124 | 124 |
| 125 success = Should('panner.panningModel = "invalid"', function () { | 125 success = Should('panner.panningModel = "invalid"', function () { |
| 126 panner.panningModel = "invalid"; | 126 panner.panningModel = "invalid"; |
| 127 }).notThrow() && success; | 127 }).notThrow() && success; |
| 128 | 128 |
| 129 success = Should("panner.panningModel", panner.panningModel) | 129 success = Should("panner.panningModel after invalid setter", panner.pann ingModel) |
|
hongchan
2017/03/22 22:09:42
Ditto.
| |
| 130 .beEqualTo("HRTF") && success; | 130 .beEqualTo("HRTF") && success; |
| 131 | 131 |
| 132 // Check that numerical values are no longer supported. We shouldn't th row and the value | 132 // Check that numerical values are no longer supported. We shouldn't th row and the value |
| 133 // shouldn't be changed. | 133 // shouldn't be changed. |
| 134 panner.panningModel = "HRTF"; | 134 panner.panningModel = "HRTF"; |
| 135 success = Should('panner.panningModel = 1', function () { | 135 success = Should('panner.panningModel = 1', function () { |
| 136 panner.panningModel = 1; | 136 panner.panningModel = 1; |
| 137 }).notThrow() && success; | 137 }).notThrow() && success; |
| 138 | 138 |
| 139 success = Should('panner.panningModel', panner.panningModel) | 139 success = Should('panner.panningModel', panner.panningModel) |
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 171 .summarize("passed", "failed"); | 171 .summarize("passed", "failed"); |
| 172 done(); | 172 done(); |
| 173 }); | 173 }); |
| 174 | 174 |
| 175 audit.runTasks(); | 175 audit.runTasks(); |
| 176 </script> | 176 </script> |
| 177 | 177 |
| 178 </body> | 178 </body> |
| 179 | 179 |
| 180 </html> | 180 </html> |
| OLD | NEW |
