Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html b/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
index 7346ff1cb0faf62d7d2ca6476b4bc613bafaedbf..a7b8332e0e91034443e77619a8b969efcdc8aed1 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html
@@ -49,24 +49,24 @@
var node;
var success = true;
- success = Should("node = new OscillatorNode(context)", function () {
+ success = Should("node0 = new OscillatorNode(context)", function () {
node = new OscillatorNode(context);
}).notThrow();
- success = Should("node instanceof OscillatorNode", node instanceof OscillatorNode)
+ success = Should("node0 instanceof OscillatorNode", node instanceof OscillatorNode)
.beEqualTo(true) && success;
- success = Should("node.type", node.type)
+ success = Should("node0.type", node.type)
.beEqualTo("sine") && success;
- success = Should("node.detune.value", node.detune.value)
+ success = Should("node0.detune.value", node.detune.value)
.beEqualTo(0) && success;
- success = Should("node.frequency.value", node.frequency.value)
+ success = Should("node0.frequency.value", node.frequency.value)
.beEqualTo(440) && success;
- success = Should("node.channelCount", node.channelCount)
+ success = Should("node0.channelCount", node.channelCount)
.beEqualTo(2) && success;
- success = Should("node.channelCountMode", node.channelCountMode)
+ success = Should("node0.channelCountMode", node.channelCountMode)
.beEqualTo("max") && success;
- success = Should("node.channelInterpretation", node.channelInterpretation)
+ success = Should("node0.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
Should("new OscillatorNode(context)", success)
@@ -91,23 +91,23 @@
frequency: 918
};
- success = Should("node = new OscillatorNode(c, " + JSON.stringify(options) + ")",
+ success = Should("node1 = new OscillatorNode(c, " + JSON.stringify(options) + ")",
function () {
node = new OscillatorNode(context, options);
}).notThrow();
- success = Should("node.type", node.type)
+ success = Should("node1.type", node.type)
.beEqualTo(options.type) && success;
- success = Should("node.detune.value", node.detune.value)
+ success = Should("node1.detune.value", node.detune.value)
.beEqualTo(options.detune) && success;
- success = Should("node.frequency.value", node.frequency.value)
+ success = Should("node1.frequency.value", node.frequency.value)
.beEqualTo(options.frequency) && success;
- success = Should("node.channelCount", node.channelCount)
+ success = Should("node1.channelCount", node.channelCount)
.beEqualTo(2) && success;
- success = Should("node.channelCountMode", node.channelCountMode)
+ success = Should("node1.channelCountMode", node.channelCountMode)
.beEqualTo("max") && success;
- success = Should("node.channelInterpretation", node.channelInterpretation)
+ success = Should("node1.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
// Test that type and periodicWave options work as described.

Powered by Google App Engine
This is Rietveld 408576698