Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html ('K') | « third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/delay.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!doctype html> 1 <!doctype html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Test Constructor: Convolver</title> 4 <title>Test Constructor: Convolver</title>
5 <script src="../../resources/testharness.js"></script> 5 <script src="../../resources/testharness.js"></script>
6 <script src="../../resources/testharnessreport.js"></script> 6 <script src="../../resources/testharnessreport.js"></script>
7 <script src="../resources/audit-util.js"></script> 7 <script src="../resources/audit-util.js"></script>
8 <script src="../resources/audio-testing.js"></script> 8 <script src="../resources/audio-testing.js"></script>
9 <script src="audionodeoptions.js"></script> 9 <script src="audionodeoptions.js"></script>
10 </head> 10 </head>
(...skipping 29 matching lines...) Expand all
40 .summarize( 40 .summarize(
41 "correctly threw errors", 41 "correctly threw errors",
42 "did not throw errors in all cases"); 42 "did not throw errors in all cases");
43 taskDone(); 43 taskDone();
44 }); 44 });
45 45
46 audit.defineTask("default constructor", function (taskDone) { 46 audit.defineTask("default constructor", function (taskDone) {
47 var node; 47 var node;
48 var success = true; 48 var success = true;
49 49
50 success = Should("node = new ConvolverNode(context)", function () { 50 success = Should("node0 = new ConvolverNode(context)", function () {
51 node = new ConvolverNode(context); 51 node = new ConvolverNode(context);
52 }).notThrow(); 52 }).notThrow();
53 success = Should("node instanceOf ConvolverNode", node instanceof Convol verNode) 53 success = Should("node0 instanceOf ConvolverNode", node instanceof Convo lverNode)
54 .beEqualTo(true) && success; 54 .beEqualTo(true) && success;
55 success = Should("node.normalize", node.normalize) 55 success = Should("node0.normalize", node.normalize)
56 .beEqualTo(true) && success; 56 .beEqualTo(true) && success;
57 57
58 success = Should("node.channelCount", node.channelCount) 58 success = Should("node0.channelCount", node.channelCount)
59 .beEqualTo(2) && success; 59 .beEqualTo(2) && success;
60 success = Should("node.channelCountMode", node.channelCountMode) 60 success = Should("node0.channelCountMode", node.channelCountMode)
61 .beEqualTo("clamped-max") && success; 61 .beEqualTo("clamped-max") && success;
62 success = Should("node.channelInterpretation", node.channelInterpretatio n) 62 success = Should("node0.channelInterpretation", node.channelInterpretati on)
63 .beEqualTo("speakers") && success; 63 .beEqualTo("speakers") && success;
64 64
65 success = Should("new AnalyserNode(context)", success) 65 success = Should("new AnalyserNode(context)", success)
66 .summarize( 66 .summarize(
67 "constructed node with correct attributes", 67 "constructed node with correct attributes",
68 "did not construct correct node correctly") 68 "did not construct correct node correctly")
69 69
70 taskDone(); 70 taskDone();
71 }); 71 });
72 72
73 audit.defineTask("test AudioNodeOptions", function (taskDone) { 73 audit.defineTask("test AudioNodeOptions", function (taskDone) {
74 testAudioNodeOptions(context, "ConvolverNode"); 74 testAudioNodeOptions(context, "ConvolverNode");
75 taskDone(); 75 taskDone();
76 }); 76 });
77 77
78 audit.defineTask("nullable buffer", function (taskDone) { 78 audit.defineTask("nullable buffer", function (taskDone) {
79 var node; 79 var node;
80 var success = true; 80 var success = true;
81 81
82 var options = { buffer: null }; 82 var options = { buffer: null };
83 83
84 success = Should("node = new ConvolverNode(c, " + JSON.stringify(options ), function () { 84 success = Should("node1 = new ConvolverNode(c, " + JSON.stringify(option s), function () {
85 node = new ConvolverNode(context, options); 85 node = new ConvolverNode(context, options);
86 }).notThrow(); 86 }).notThrow();
87 87
88 success = Should("node.buffer", node.buffer) 88 success = Should("node1.buffer", node.buffer)
89 .beEqualTo(null); 89 .beEqualTo(null);
90 90
91 Should("Null buffer in constructor handled", success) 91 Should("Null buffer in constructor handled", success)
92 .summarize( 92 .summarize(
93 "correctly", 93 "correctly",
94 "incorrectly"); 94 "incorrectly");
95 95
96 taskDone(); 96 taskDone();
97 }); 97 });
98 98
99 audit.defineTask("construct with options", function (taskDone) { 99 audit.defineTask("construct with options", function (taskDone) {
100 var buf = context.createBuffer(1, 1, context.sampleRate); 100 var buf = context.createBuffer(1, 1, context.sampleRate);
101 var options = { 101 var options = {
102 buffer: buf, 102 buffer: buf,
103 disableNormalization: false 103 disableNormalization: false
104 }; 104 };
105 105
106 var message = "node = new ConvolverNode(c, " + JSON.stringify(options) + ")"; 106 var message = "node = new ConvolverNode(c, " + JSON.stringify(options) + ")";
107 107
108 var node; 108 var node;
109 success = Should(message, function () { 109 success = Should(message, function () {
110 node = new ConvolverNode(context, options); 110 node = new ConvolverNode(context, options);
111 }).notThrow(); 111 }).notThrow();
112 112
113 success = Should("node instanceOf ConvolverNode", node instanceof Convol verNode) 113 success = Should("node1 instanceOf ConvolverNode", node instanceof Convo lverNode)
114 .beEqualTo(true) && success; 114 .beEqualTo(true) && success;
115 success = Should("node.buffer === <buf>", node.buffer === 115 success = Should("node1.buffer === <buf>", node.buffer ===
116 options.buffer) 116 options.buffer)
117 .beEqualTo(true) && success; 117 .beEqualTo(true) && success;
118 success = Should("node.normalize", node.normalize) 118 success = Should("node1.normalize", node.normalize)
119 .beEqualTo(!options.disableNormalization) && success; 119 .beEqualTo(!options.disableNormalization) && success;
120 120
121 options.buffer = null; 121 options.buffer = null;
122 options.disableNormalization = true; 122 options.disableNormalization = true;
123 123
124 message = "node = new ConvolverNode(, " + JSON.stringify(options) + ")"; 124 message = "node2 = new ConvolverNode(, " + JSON.stringify(options) + ")" ;
125 125
126 success = Should(message, function () { 126 success = Should(message, function () {
127 node = new ConvolverNode(context, options); 127 node = new ConvolverNode(context, options);
128 }).notThrow() && success; 128 }).notThrow() && success;
129 success = Should("node.buffer", node.buffer).beEqualTo(null) && success; 129 success = Should("node2.buffer", node.buffer).beEqualTo(null) && success ;
130 success = Should("node.normalize", node.normalize) 130 success = Should("node2.normalize", node.normalize)
131 .beEqualTo(!options.disableNormalization) && success; 131 .beEqualTo(!options.disableNormalization) && success;
132 132
133 options.disableNormalization = false; 133 options.disableNormalization = false;
134 message = "node = new ConvolverNode(context, " + JSON.stringify(options) + ")"; 134 message = "node3 = new ConvolverNode(context, " + JSON.stringify(options ) + ")";
135 135
136 success = Should(message, function () { 136 success = Should(message, function () {
137 node = new ConvolverNode(context, options); 137 node = new ConvolverNode(context, options);
138 }).notThrow() && success; 138 }).notThrow() && success;
139 success = Should("node.buffer", node.buffer).beEqualTo(null) && success; 139 success = Should("node3.buffer", node.buffer).beEqualTo(null) && success ;
140 success = Should("node.normalize", node.normalize) 140 success = Should("node3.normalize", node.normalize)
141 .beEqualTo(!options.disableNormalization) && success; 141 .beEqualTo(!options.disableNormalization) && success;
142 142
143 Should("new ConvolverNode() with options", success) 143 Should("new ConvolverNode() with options", success)
144 .summarize( 144 .summarize(
145 "constructed with correct attributes", 145 "constructed with correct attributes",
146 "was not constructed correctly"); 146 "was not constructed correctly");
147 147
148 taskDone(); 148 taskDone();
149 }); 149 });
150 150
151 audit.runTasks(); 151 audit.runTasks();
152 </script> 152 </script>
153 </body> 153 </body>
154 </html> 154 </html>
OLDNEW
« third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html ('K') | « third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html ('k') | third_party/WebKit/LayoutTests/webaudio/constructor/delay.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698