Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
index ed9ae4c59bb1e1c82d2737fce20de02294e45b46..4d2c31a969b7bcf94aa8cc334fe6113e72b1f3ab 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html
@@ -104,12 +104,13 @@
expected[k] = Math.sin(omega * (k - startFrame));
}
- should(actual, "Oscillator.start(" + startFrame + " frames)")
+ let prefix = "Oscillator.start(" + startFrame + " frames)";
+ should(actual, prefix)
.beCloseToArray(expected, {
absoluteThreshold: thresholds.error
});
let snr = 10 * Math.log10(computeSNR(actual, expected));
- should(snr, "SNR (dB)")
+ should(snr, prefix + ": SNR (dB)")
.beGreaterThanOrEqualTo(thresholds.snrThreshold);
})
}
@@ -169,11 +170,12 @@
let oscGain = result.getChannelData(2);
let snr = 10 * Math.log10(computeSNR(oscStart, oscGain));
- should(oscStart, "Delayed cosine oscillator at sample rate " + sampleRate)
+ let prefix = "Sample rate " + sampleRate + ": Delayed cosine oscillator";
hongchan 2017/03/22 22:09:41 Wrap at 80.
+ should(oscStart, prefix)
.beCloseToArray(oscGain, {
absoluteThreshold: thresholds.error
});
- should(snr, "SNR (dB)")
+ should(snr, prefix + ": SNR (dB)")
.beGreaterThanOrEqualTo(thresholds.snrThreshold);
});
}

Powered by Google App Engine
This is Rietveld 408576698