Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html

Issue 2768983002: Fix duplicate test names in WebAudio tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
index 1a867aec8d823b8da08ea9e25b9e981a9cfef4c9..a86a096b445b4bdb6d77ae13bd75c2b0551ec4a6 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
@@ -205,14 +205,15 @@
source.start();
// Some consistency checks on the test parameters
- Should("Check: Curve end time", config.curveStartTime + config.curveDuration, {
+ let prefix = "Length " + config.curveLength + ", duration " + config.curveDuration;
hongchan 2017/03/22 22:09:41 Let's wrap at 80.
+ Should(prefix + ": Check: Curve end time", config.curveStartTime + config.curveDuration, {
brief: true
})
.beLessThanOrEqualTo(testDurationSec);
- Should("Check: Full gain start time", config.fullGainTime, {
+ Should(prefix + ": Check: Full gain start time", config.fullGainTime, {
brief: true
}).beLessThanOrEqualTo(testDurationSec);
- Should("Check: Full gain start time", config.fullGainTime, {
+ Should(prefix + ": Check: Full gain start time", config.fullGainTime, {
brief: true
}).beGreaterThanOrEqualTo(config.curveStartTime + config.curveDuration);
@@ -241,11 +242,12 @@
}
}
- success = success && Should("SNR", SNR, {
+ let prefix = "Curve length " + config.curveLength + ", duration " + config.curveDuration;
hongchan 2017/03/22 22:09:41 Ditto.
+ success = success && Should(prefix + ": SNR", SNR, {
brief: true
}).beGreaterThanOrEqualTo(config.snrThreshold);
- success = Should("Max difference", maxDiff)
+ success = Should(prefix + ": Max difference", maxDiff)
.beLessThanOrEqualTo(config.maxErrorThreshold) && success;
var message = "Test: curve length = " + config.curveLength +

Powered by Google App Engine
This is Rietveld 408576698