Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Created:
3 years, 10 months ago by sullivan
Modified:
3 years, 10 months ago
Reviewers:
nednguyen, perezju
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (patchset #3 id:40001 of https://codereview.chromium.org/2687773003/ ) Reason for revert: Broke telemetry_perf_unittests. See https://github.com/catapult-project/catapult/issues/3208 Original issue's description: > [Telemetry] Switch clients to new JavaScript API (batch 5) > > Clients are switched to use EvaluateJavaScript2, ExecuteJavaScript2, and > WaitForJavaScriptCondition2. > > Several cases of unsafe interpolation are fixed in the process. > > Also adds the option to interpolate a list of *args. > > BUG=catapult:#3028 > > Review-Url: https://codereview.chromium.org/2687773003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/21c13dbde78ea46c452de6fc8d583e3a88be9780 TBR=nednguyen@google.com,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#3028 Review-Url: https://codereview.chromium.org/2692763002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67cf0dc183f8a484495aa7eb1984f241835d01c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -241 lines) Patch
M telemetry/examples/browser_tests/simple_browser_test.py View 2 chunks +7 lines, -8 lines 0 comments Download
M telemetry/telemetry/core/local_server_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/core/memory_cache_http_server_unittest.py View 2 chunks +9 lines, -10 lines 0 comments Download
M telemetry/telemetry/core/tracing_controller_unittest.py View 1 chunk +4 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 3 chunks +9 lines, -7 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_test_case.py View 2 chunks +6 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_unittest.py View 2 chunks +17 lines, -15 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome/oobe.py View 6 chunks +33 lines, -27 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py View 1 chunk +5 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_memory_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py View 1 chunk +5 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime_unittest.py View 5 chunks +12 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/backends/form_based_credentials_backend.py View 2 chunks +14 lines, -15 lines 0 comments Download
M telemetry/telemetry/internal/backends/form_based_credentials_backend_unittest_base.py View 2 chunks +10 lines, -13 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/browser/browser_info.py View 1 chunk +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/browser/extension_unittest.py View 5 chunks +10 lines, -10 lines 0 comments Download
M telemetry/telemetry/internal/browser/tab.py View 3 chunks +35 lines, -35 lines 0 comments Download
M telemetry/telemetry/internal/browser/tab_unittest.py View 5 chunks +11 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/browser/user_agent_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py View 2 chunks +8 lines, -7 lines 0 comments Download
M telemetry/telemetry/page/cache_temperature.py View 1 chunk +16 lines, -10 lines 0 comments Download
M telemetry/telemetry/page/legacy_page_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/page/page_run_end_to_end_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download
M telemetry/telemetry/page/page_test_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/util/js_template.py View 3 chunks +6 lines, -13 lines 0 comments Download
M telemetry/telemetry/util/js_template_unittest.py View 1 chunk +0 lines, -6 lines 0 comments Download
M telemetry/telemetry/value/histogram_util.py View 1 chunk +4 lines, -3 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sullivan
Created Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)
3 years, 10 months ago (2017-02-12 19:01:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692763002/1
3 years, 10 months ago (2017-02-12 19:01:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67cf0dc183f8a484495aa7eb1984f241835d01c1
3 years, 10 months ago (2017-02-12 19:23:02 UTC) #6
perezju
3 years, 10 months ago (2017-02-15 10:16:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2693923005/ by perezju@chromium.org.

The reason for reverting is: Chromium side test that started failing got fixed
at:
https://codereview.chromium.org/2694163003/.

Powered by Google App Engine
This is Rietveld 408576698