Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: telemetry/telemetry/page/page_test_unittest.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | telemetry/telemetry/util/js_template.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/page_test_unittest.py
diff --git a/telemetry/telemetry/page/page_test_unittest.py b/telemetry/telemetry/page/page_test_unittest.py
index 63d6ea8c4f960de762dd3bc6df81a49797b5da7a..f4cc3bf9a06c3a5065a5f28f797884fc085e7a19 100644
--- a/telemetry/telemetry/page/page_test_unittest.py
+++ b/telemetry/telemetry/page/page_test_unittest.py
@@ -25,7 +25,7 @@
class PageTestForBlank(legacy_page_test.LegacyPageTest):
def ValidateAndMeasurePage(self, page, tab, results):
- contents = tab.EvaluateJavaScript2('document.body.textContent')
+ contents = tab.EvaluateJavaScript('document.body.textContent')
if contents.strip() != 'Hello world':
raise legacy_page_test.MeasurementFailure(
'Page contents were: ' + contents)
@@ -35,7 +35,7 @@
def ValidateAndMeasurePage(self, page, tab, results):
# Web Page Replay returns '404 Not found' if a page is not in the archive.
- contents = tab.EvaluateJavaScript2('document.body.textContent')
+ contents = tab.EvaluateJavaScript('document.body.textContent')
if '404 Not Found' in contents.strip():
raise legacy_page_test.MeasurementFailure('Page not in archive.')
@@ -43,7 +43,7 @@
class PageTestQueryParams(legacy_page_test.LegacyPageTest):
def ValidateAndMeasurePage(self, page, tab, results):
- query = tab.EvaluateJavaScript2('window.location.search')
+ query = tab.EvaluateJavaScript('window.location.search')
expected = '?foo=1'
if query.strip() != expected:
raise legacy_page_test.MeasurementFailure(
« no previous file with comments | « telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | telemetry/telemetry/util/js_template.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698