telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py - Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

diff --git a/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py b/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

index 0d54962c2a99de503b888f536bfb61218c3476d7..c4e98f317b00569cef0a253441330ec46ea127e8 100644

--- a/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

+++ b/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

@@ -101,7 +101,7 @@

try:

inspector = inspector_backend.InspectorBackend(

backend.app, backend.devtools_client, context)

- res = inspector.EvaluateJavaScript2("navigator.userAgent")

+ res = inspector.EvaluateJavaScript("navigator.userAgent")

finally:

inspector.Disconnect()

match_browsers = re.search(browser_pattern, res)