[Telemetry] Switch clients to new JavaScript API (batch 5)

[Telemetry] Switch clients to new JavaScript API (batch 5)

Clients are switched to use EvaluateJavaScript2, ExecuteJavaScript2, and
WaitForJavaScriptCondition2.

Several cases of unsafe interpolation are fixed in the process.

Also adds the option to interpolate a list of *args.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2687773003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/21c13dbde78ea46c452de6fc8d583e3a88be9780

[perezju, 2017-02-09 15:29:09]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com

[perezju, 2017-02-09 15:29:10]

And this should be the final batch!

https://codereview.chromium.org/2687773003/diff/20001/telemetry/telemetry/uti...
File telemetry/telemetry/util/js_template.py (right):

https://codereview.chromium.org/2687773003/diff/20001/telemetry/telemetry/uti...
telemetry/telemetry/util/js_template.py:26: commas.
I'm adding this new option, as it turned out to be quite useful. See test case
in unit tests and backends/chrome/oobe.py for example usage.

Hopefully it's fine to include it here, but wouldn't mind if you prefer me to
land this change as a separate CL.

[nednguyen, 2017-02-09 17:08:08]

lgtm

[perezju, 2017-02-10 10:34:47]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:34:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:46:27]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[perezju, 2017-02-10 12:19:14]

Just hacked enough the tests for the (deprecated) form_based_credentials_backend
to pass.

[perezju, 2017-02-10 12:19:24]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-02-10 12:19:25]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2687773003/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2017-02-10 12:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 12:40:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486729164937250,
"parent_rev": "a6b212171e82727cc72fd23588bc9dcf1af4f9de", "commit_rev":
"21c13dbde78ea46c452de6fc8d583e3a88be9780"}

[commit-bot: I haz the power, 2017-02-10 12:40:54]

Description was changed from

==========
[Telemetry] Switch clients to new JavaScript API (batch 5)

Clients are switched to use EvaluateJavaScript2, ExecuteJavaScript2, and
WaitForJavaScriptCondition2.

Several cases of unsafe interpolation are fixed in the process.

Also adds the option to interpolate a list of *args.

BUG=catapult:#3028
==========

to

==========
[Telemetry] Switch clients to new JavaScript API (batch 5)

Clients are switched to use EvaluateJavaScript2, ExecuteJavaScript2, and
WaitForJavaScriptCondition2.

Several cases of unsafe interpolation are fixed in the process.

Also adds the option to interpolate a list of *args.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2687773003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-10 12:40:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[sullivan, 2017-02-12 19:01:05]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2692763002/ by sullivan@chromium.org.

The reason for reverting is: Broke telemetry_perf_unittests. See
https://github.com/catapult-project/catapult/issues/3208.