Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: telemetry/telemetry/internal/browser/user_agent_unittest.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/browser/tab_unittest.py ('k') | telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/browser/user_agent_unittest.py
diff --git a/telemetry/telemetry/internal/browser/user_agent_unittest.py b/telemetry/telemetry/internal/browser/user_agent_unittest.py
index 3c865b774a7ad414939d0dd84ebe4288b85c9052..19c5d6850bebdae99139c6b3a5a0ab3cbaf4be5c 100644
--- a/telemetry/telemetry/internal/browser/user_agent_unittest.py
+++ b/telemetry/telemetry/internal/browser/user_agent_unittest.py
@@ -14,7 +14,7 @@
@decorators.Disabled('chromeos') # crbug.com/483212
def testUserAgent(self):
- ua = self._tab.EvaluateJavaScript2('window.navigator.userAgent')
+ ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['mobile'])
class TabletUserAgentTest(tab_test_case.TabTestCase):
@@ -24,7 +24,7 @@
@decorators.Disabled('chromeos') # crbug.com/483212
def testUserAgent(self):
- ua = self._tab.EvaluateJavaScript2('window.navigator.userAgent')
+ ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['tablet'])
class DesktopUserAgentTest(tab_test_case.TabTestCase):
@@ -34,5 +34,5 @@
@decorators.Disabled('chromeos') # crbug.com/483212
def testUserAgent(self):
- ua = self._tab.EvaluateJavaScript2('window.navigator.userAgent')
+ ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['desktop'])
« no previous file with comments | « telemetry/telemetry/internal/browser/tab_unittest.py ('k') | telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698