telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py - Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/user_agent_unittest.py ('k') | telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py b/telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py

index e6f1bb83c4448209d9834ff38fa2167338073150..a11ae4cd6466dd399b2b084184e3f877227deafd 100644

--- a/telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/tcmalloc_heap_profiler.py

@@ -137,7 +137,7 @@

# This is a minor optimization to ensure it'll dump the last file when

# the test completes.

for i in xrange(len(browser_backend.browser.tabs)):

- browser_backend.browser.tabs[i].ExecuteJavaScript2("""

+ browser_backend.browser.tabs[i].ExecuteJavaScript("""

if (chrome && chrome.memoryBenchmarking) {

chrome.memoryBenchmarking.heapProfilerDump('renderer', 'final');

chrome.memoryBenchmarking.heapProfilerDump('browser', 'final');