telemetry/telemetry/page/legacy_page_test.py - Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/legacy_page_test.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/legacy_page_test.py

diff --git a/telemetry/telemetry/page/legacy_page_test.py b/telemetry/telemetry/page/legacy_page_test.py

index 37f9c3c8ab087a21733c6f8bd4c10dbf07254b5c..47b6f800b3ac6ab46a1f595a9173385e7738d0eb 100644

--- a/telemetry/telemetry/page/legacy_page_test.py

+++ b/telemetry/telemetry/page/legacy_page_test.py

@@ -49,7 +49,7 @@

class BodyChildElementMeasurement(LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

- body_child_count = tab.EvaluateJavaScript2(

+ body_child_count = tab.EvaluateJavaScript(

'document.body.children.length')

results.AddValue(scalar.ScalarValue(

page, 'body_children', 'count', body_child_count))

@@ -171,7 +171,7 @@

Put together:

def ValidateAndMeasurePage(self, page, tab, results):

- res = tab.EvaluateJavaScript2('2+2')

+ res = tab.EvaluateJavaScript('2+2')

if res != 4:

raise Exception('Oh, wow.')

results.AddValue(scalar.ScalarValue(