Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: telemetry/telemetry/core/tracing_controller_unittest.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/core/tracing_controller_unittest.py
diff --git a/telemetry/telemetry/core/tracing_controller_unittest.py b/telemetry/telemetry/core/tracing_controller_unittest.py
index f0f7bc3a514d9b936c26220d7a97eb7ca438a883..ec91aafec4083784c11a4f6dfc69249a1aa18559 100644
--- a/telemetry/telemetry/core/tracing_controller_unittest.py
+++ b/telemetry/telemetry/core/tracing_controller_unittest.py
@@ -72,8 +72,10 @@
tab = self._browser.tabs[0]
def InjectMarker(index):
marker = 'test-marker-%d' % index
- tab.EvaluateJavaScript2('console.time({{ marker }});', marker=marker)
- tab.EvaluateJavaScript2('console.timeEnd({{ marker }});', marker=marker)
+ # TODO(catapult:#3028): Fix interpolation of JavaScript values.
+ tab.EvaluateJavaScript('console.time("%s");' % marker)
+ # TODO(catapult:#3028): Fix interpolation of JavaScript values.
+ tab.EvaluateJavaScript('console.timeEnd("%s");' % marker)
# Set up the tracing config.
tracing_controller = self._browser.platform.tracing_controller

Powered by Google App Engine
This is Rietveld 408576698