Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
index e21aa5c8210d2b8d072f5f5bed1de5d65c77d8c3..935b8dfaab2d2fb7db7a2ec8edcd248ff75453cc 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
@@ -14,26 +14,26 @@
def testCustomActionToNavigate(self):
self.Navigate('page_with_link.html')
self.assertEquals(
- self._tab.EvaluateJavaScript2('document.location.pathname;'),
+ self._tab.EvaluateJavaScript('document.location.pathname;'),
'/page_with_link.html')
- self._tab.ExecuteJavaScript2('document.getElementById("clickme").click();')
+ self._tab.ExecuteJavaScript('document.getElementById("clickme").click();')
self._tab.WaitForNavigate()
self.assertEquals(
- self._tab.EvaluateJavaScript2('document.location.pathname;'),
+ self._tab.EvaluateJavaScript('document.location.pathname;'),
'/blank.html')
def testGetCookieByName(self):
self.Navigate('blank.html')
- self._tab.ExecuteJavaScript2('document.cookie="foo=bar"')
+ self._tab.ExecuteJavaScript('document.cookie="foo=bar"')
self.assertEquals(self._tab.GetCookieByName('foo'), 'bar')
def testScriptToEvaluateOnCommit(self):
self.Navigate('blank.html',
script_to_evaluate_on_commit='var foo = "bar";')
self._tab.WaitForDocumentReadyStateToBeComplete()
- self.assertEquals(self._tab.EvaluateJavaScript2('foo'), 'bar')
+ self.assertEquals(self._tab.EvaluateJavaScript('foo'), 'bar')
@decorators.Disabled('chromeos') # crbug.com/483212
def testCaptureScreenshot(self):

Powered by Google App Engine
This is Rietveld 408576698