telemetry/telemetry/internal/browser/browser.py - Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/browser.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/browser/browser.py

diff --git a/telemetry/telemetry/internal/browser/browser.py b/telemetry/telemetry/internal/browser/browser.py

index c2971d6135509ca0d9c3ad7a8bee24a416b47ebe..2d40e64ea7a3239cc34f808675dd8688caf36396 100644

--- a/telemetry/telemetry/internal/browser/browser.py

+++ b/telemetry/telemetry/internal/browser/browser.py

@@ -98,7 +98,7 @@

# which means that tabs that have never been in the foreground return

# document.hidden as false; however in current code the Android foreground

# tab is always tab 0, which will be the first one that isn't hidden

- if self._tabs[i].EvaluateJavaScript2('!document.hidden'):

+ if self._tabs[i].EvaluateJavaScript('!document.hidden'):

return self._tabs[i]

raise Exception("No foreground tab found")