telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py - Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

Issue 2692763002: Revert of [Telemetry] Switch clients to new JavaScript API (batch 5) (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/inspector_memory_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

index 576794d086ff61f930af69faff6f540d3f9803ee..858568e36ac23a1422a8fb6bb3bb000baf7c8383 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

@@ -13,9 +13,9 @@

def testConsoleOutputStream(self):

self.Navigate('page_that_logs_to_console.html')

- initial = self._tab.EvaluateJavaScript2('window.__logCount')

+ initial = self._tab.EvaluateJavaScript('window.__logCount')

def GotLog():

- current = self._tab.EvaluateJavaScript2('window.__logCount')

+ current = self._tab.EvaluateJavaScript('window.__logCount')

return current > initial

py_utils.WaitFor(GotLog, 5)