Rename toV8(...) function in Blink to ToV8(...).

Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7
Cr-Commit-Position: refs/heads/master@{#441555}

[Łukasz Anforowicz, 2016-12-20 17:36:36]

Description was changed from

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

BUG=675228
==========

to

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Łukasz Anforowicz, 2016-12-20 17:36:39]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 17:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-20 17:38:03]

Description was changed from

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-20 20:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:22:43]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-12-20 22:15:00]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-20 22:15:02]

dcheng@, could you PTAL?

1. Please let me know if I should hold off with landing this (I assume the
answer is no, but want to double-check) - e.g. if I should wait for a go/no-go
decision for the "big rename" before landing this.

2. Please add more reviewers as you see fit.

3. Please let me know if you have any suggestions for the CL description (I
think you wanted to send a PSA about prelanding targeted, manual CLs for
ChromiumStyle conversion  - maybe I should link the PSA from CL description?).

[dcheng, 2016-12-20 22:19:36]

Would it be a lot of trouble to hold off until we send the PSA and get some
initial responses? I don't think anyone will be too opposed to these changes,
but let's make sure =)

[dcheng, 2016-12-20 22:19:54]

(Basically I'm writing up the PSA right now, and I'd like to give ~1 day for
responses)

[Łukasz Anforowicz, 2016-12-20 22:38:15]

On 2016/12/20 22:19:36, dcheng wrote:
> Would it be a lot of trouble to hold off until we send the PSA and get some
> initial responses? I don't think anyone will be too opposed to these changes,
> but let's make sure =)

SGTM

[haraken, 2016-12-21 00:00:56]

LGTM if there's no objection on the PSA.

[Yuki, 2016-12-21 06:37:35]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-12-21 06:37:36]

LGTM, too.

[dcheng, 2016-12-22 07:23:00]

LGTM. No responses, so I guess everyone's on holiday =)

[Łukasz Anforowicz, 2016-12-22 18:53:11]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-22 18:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 19:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 19:57:21]

Failed to apply patch for
third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h:127
  error: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h:
patch does not apply

Patch:       third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
index
489183609fb3db8c8f08d48ca3bf8d3c230edde6..cd645277bc3d8e5137a731f47617986b788c875b
100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
@@ -127,7 +127,7 @@ class CORE_EXPORT ScriptPromiseResolver
 
     ScriptState::Scope scope(m_scriptState.get());
     m_value.set(m_scriptState->isolate(),
-                toV8(value, m_scriptState->context()->Global(),
+                ToV8(value, m_scriptState->context()->Global(),
                      m_scriptState->isolate()));
 
     if (getExecutionContext()->activeDOMObjectsAreSuspended()) {

[Łukasz Anforowicz, 2016-12-28 20:54:49]

Description was changed from

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Łukasz Anforowicz, 2016-12-28 20:58:54]

+nasko@ to CC

Thank you for the reviews everyone.  I haven't yet landed this CL, because we
are still evaluating an option of automatically rewriting identifiers that are
declared in generated code.  Today such identifiers are skipped, but if they
were automatically renamed, then it wouldn't be necessary to pre-land the toV8
-> ToV8 CL.  To make a decision, we need to evaluate how feasible it is to
proceed without renaming identifiers that are declared in generated code:

1. Evaluate how much remaining renames would have to be done later.
2. Evaluate if it is possible to tweak code generation in such a way that A)
identifiers declared in non-generated code and called from generated code are
renamed if needed and B) identifiers declared in generated code are not renamed.
 AFAIK nasko@ (in CC) is close to being able to make this call.

[Łukasz Anforowicz, 2017-01-04 22:08:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 22:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-04 22:36:46]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-01-04 22:36:54]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-01-04 22:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcheng@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2595543003/#ps20001
(title: "Rebasing...")

[commit-bot: I haz the power, 2017-01-04 22:37:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:41:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2017-01-05 01:45:16]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:45:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:53:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483580716146440,
"parent_rev": "cfcb50c535c63dd0a2cefb7d2027280fbb982370", "commit_rev":
"0d4bb556a5e714606e3382b1c58dbbbb8f288e41"}

[commit-bot: I haz the power, 2017-01-05 01:53:57]

Description was changed from

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2595543003
==========

[commit-bot: I haz the power, 2017-01-05 01:53:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-05 01:58:05]

Description was changed from

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2595543003
==========

to

==========
Rename toV8(...) function in Blink to ToV8(...).

This CL effectively changes the style of the function to ChromiumStyle.
Prelanding this CL before the "big rename" is needed to help the
renaming tool consistently deal with generated and non-generated code.
(toV8 is one of few functions that have overloads declared both in
generated and in non-generated code).

This CL was generated with the help of the following commands:
  $ cd third_party/WebKit/Source
  $ ag '\btoV8\b' -l | xargs -n 1 sed -e 's/\btoV8\b(/ToV8(/' -i

BUG=675228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7
Cr-Commit-Position: refs/heads/master@{#441555}
==========

[commit-bot: I haz the power, 2017-01-05 01:58:07]

Patchset 2 (id:??) landed as
https://crrev.com/4367352829a637bf5f3c7831c5e43f1d362d52d7
Cr-Commit-Position: refs/heads/master@{#441555}