Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)
Patch Set: Rebasing... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
index 0cfb99f9a7bf48fbdcab9b2d3c77f266887ccfa7..b877724d34d4c04e286a2b8bab2d6adba781a1e8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
@@ -85,7 +85,7 @@ TEST(ScriptWrappableVisitorTest, OilpanCollectObjectsNotReachableFromV8) {
DeathAwareScriptWrappable::observeDeathsOf(object);
// Creates new V8 wrapper and associates it with global scope
- toV8(object, scope.context()->Global(), isolate);
+ ToV8(object, scope.context()->Global(), isolate);
}
runV8Scavenger(isolate);
@@ -106,7 +106,7 @@ TEST(ScriptWrappableVisitorTest, OilpanDoesntCollectObjectsReachableFromV8) {
DeathAwareScriptWrappable::observeDeathsOf(object);
// Creates new V8 wrapper and associates it with global scope
- toV8(object, scope.context()->Global(), isolate);
+ ToV8(object, scope.context()->Global(), isolate);
runV8Scavenger(isolate);
runV8FullGc(isolate);
@@ -126,7 +126,7 @@ TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringScavenger) {
DeathAwareScriptWrappable::observeDeathsOf(object);
v8::Local<v8::Value> wrapper =
- toV8(object, scope.context()->Global(), isolate);
+ ToV8(object, scope.context()->Global(), isolate);
EXPECT_TRUE(wrapper->IsObject());
v8::Local<v8::Object> wrapperObject = wrapper->ToObject();
// V8 collects wrappers with unmodified maps (as they can be recreated
@@ -151,7 +151,7 @@ TEST(ScriptWrappableVisitorTest, V8ReportsLiveObjectsDuringFullGc) {
DeathAwareScriptWrappable* object = DeathAwareScriptWrappable::create();
DeathAwareScriptWrappable::observeDeathsOf(object);
- toV8(object, scope.context()->Global(), isolate);
+ ToV8(object, scope.context()->Global(), isolate);
runV8Scavenger(isolate);
runV8FullGc(isolate);

Powered by Google App Engine
This is Rietveld 408576698