third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/union_container.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

index 6c9793e1bd74ca6e7af5825a5e774ffc7d297cca..ac99c69cd21e220fd2fcfd6f84f80fe36bf5df0d 100644

--- a/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl

@@ -181,7 +181,7 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{

{% endif %}

}

-v8::Local<v8::Value> toV8(const {{cpp_class}}& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate) {

+v8::Local<v8::Value> ToV8(const {{cpp_class}}& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate) {

switch (impl.m_type) {

case {{cpp_class}}::SpecificTypeNone:

{# FIXME: We might want to return undefined in some cases #}