third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index 412a9df6e81537ad6a75346ed36922528b74761e..56cab785dd493e91872aa22407f416df297c17a0 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -44,7 +44,7 @@ bool {{cpp_class}}::call({{argument_declarations | join(', ')}}) {

v8::Local<v8::Value> {{argument.argument_name}} = {{argument.cpp_value_to_v8_value}};

{% endfor %}

- v8::Local<v8::Value> thisValue = toV8(scriptWrappable, m_scriptState->context()->Global(), m_scriptState->isolate());

+ v8::Local<v8::Value> thisValue = ToV8(scriptWrappable, m_scriptState->context()->Global(), m_scriptState->isolate());

{% if arguments %}

v8::Local<v8::Value> argv[] = { {{arguments | join(', ', 'argument_name')}} };