third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp

index 5deb10b9bf44ab27e805d9cfae6874a7f42fb799..53a848fc01649a3cbcbbaff3a2f1f2895a233c0d 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp

@@ -82,12 +82,12 @@ void V8TestInterfaceGarbageCollectedOrString::toImpl(v8::Isolate* isolate, v8::L

}

-v8::Local<v8::Value> toV8(const TestInterfaceGarbageCollectedOrString& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate) {

+v8::Local<v8::Value> ToV8(const TestInterfaceGarbageCollectedOrString& impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate) {

switch (impl.m_type) {

case TestInterfaceGarbageCollectedOrString::SpecificTypeNone:

return v8::Null(isolate);

case TestInterfaceGarbageCollectedOrString::SpecificTypeTestInterfaceGarbageCollected:

- return toV8(impl.getAsTestInterfaceGarbageCollected(), creationContext, isolate);

+ return ToV8(impl.getAsTestInterfaceGarbageCollected(), creationContext, isolate);

case TestInterfaceGarbageCollectedOrString::SpecificTypeString:

return v8String(isolate, impl.getAsString());

default: