third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

index c1642c55396820dd2d79407cb5c77945b29d0555..8e2ca5ff72921208fcc3f0ac73470a07932767fd 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

@@ -27,14 +27,14 @@ void V8ResizeObserverCallback::handleEvent(

if (m_callback.isEmpty())

return;

- v8::Local<v8::Value> observerHandle = toV8(

+ v8::Local<v8::Value> observerHandle = ToV8(

observer, m_scriptState->context()->Global(), m_scriptState->isolate());

if (!observerHandle->IsObject())

return;

v8::Local<v8::Object> thisObject =

v8::Local<v8::Object>::Cast(observerHandle);

- v8::Local<v8::Value> entriesHandle = toV8(

+ v8::Local<v8::Value> entriesHandle = ToV8(

entries, m_scriptState->context()->Global(), m_scriptState->isolate());

if (entriesHandle.IsEmpty())

return;