Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)
Patch Set: Rebasing... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index ec7af0a77932b25708de186b51475696705c99ab..cb0ac41639e5427b6945eb8839fece86dd4e4b41 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -884,9 +884,9 @@ CPP_VALUE_TO_V8_VALUE = {
'ScriptValue': '{cpp_value}.v8Value()',
'SerializedScriptValue': 'v8Deserialize({isolate}, {cpp_value})',
# General
- 'array': 'toV8({cpp_value}, {creation_context}, {isolate})',
- 'FrozenArray': 'freezeV8Object(toV8({cpp_value}, {creation_context}, {isolate}), {isolate})',
- 'DOMWrapper': 'toV8({cpp_value}, {creation_context}, {isolate})',
+ 'array': 'ToV8({cpp_value}, {creation_context}, {isolate})',
+ 'FrozenArray': 'freezeV8Object(ToV8({cpp_value}, {creation_context}, {isolate}), {isolate})',
+ 'DOMWrapper': 'ToV8({cpp_value}, {creation_context}, {isolate})',
# Passing nullable dictionaries isn't a pattern currently used
# anywhere in the web platform, and more work would be needed in
# the code generator to distinguish between passing null, and
@@ -897,7 +897,7 @@ CPP_VALUE_TO_V8_VALUE = {
# nullable dictionary type.
#
# Union types or dictionaries
- 'DictionaryOrUnion': 'toV8({cpp_value}, {creation_context}, {isolate})',
+ 'DictionaryOrUnion': 'ToV8({cpp_value}, {creation_context}, {isolate})',
}

Powered by Google App Engine
This is Rietveld 408576698