Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)
Patch Set: Rebasing... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
index 3647697c2c67bcb36ce1dcb0facee68815be2d60..68399b5eeacd312220041b86418842008f0e9a7f 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
@@ -328,7 +328,7 @@ v8::MaybeLocal<v8::Value> MainThreadDebugger::memoryInfo(
ExecutionContext* executionContext = toExecutionContext(context);
DCHECK(executionContext);
ASSERT(executionContext->isDocument());
- return toV8(MemoryInfo::create(), context->Global(), isolate);
+ return ToV8(MemoryInfo::create(), context->Global(), isolate);
}
void MainThreadDebugger::installAdditionalCommandLineAPI(
@@ -377,7 +377,7 @@ void MainThreadDebugger::querySelectorCallback(
if (exceptionState.hadException())
return;
if (element)
- info.GetReturnValue().Set(toV8(element, info.Holder(), info.GetIsolate()));
+ info.GetReturnValue().Set(ToV8(element, info.Holder(), info.GetIsolate()));
else
info.GetReturnValue().Set(v8::Null(info.GetIsolate()));
}
@@ -395,7 +395,7 @@ void MainThreadDebugger::querySelectorAllCallback(
ExceptionState exceptionState(info.GetIsolate(),
ExceptionState::ExecutionContext,
"CommandLineAPI", "$$");
- // toV8(elementList) doesn't work here, since we need a proper Array instance,
+ // ToV8(elementList) doesn't work here, since we need a proper Array instance,
// not NodeList.
StaticElementList* elementList = toContainerNode(node)->querySelectorAll(
AtomicString(selector), exceptionState);
@@ -407,7 +407,7 @@ void MainThreadDebugger::querySelectorAllCallback(
for (size_t i = 0; i < elementList->length(); ++i) {
Element* element = elementList->item(i);
if (!createDataPropertyInArray(
- context, nodes, i, toV8(element, info.Holder(), info.GetIsolate()))
+ context, nodes, i, ToV8(element, info.Holder(), info.GetIsolate()))
.FromMaybe(false))
return;
}
@@ -434,13 +434,13 @@ void MainThreadDebugger::xpathSelectorCallback(
if (exceptionState.hadException() || !result)
return;
if (result->resultType() == XPathResult::kNumberType) {
- info.GetReturnValue().Set(toV8(result->numberValue(exceptionState),
+ info.GetReturnValue().Set(ToV8(result->numberValue(exceptionState),
info.Holder(), info.GetIsolate()));
} else if (result->resultType() == XPathResult::kStringType) {
- info.GetReturnValue().Set(toV8(result->stringValue(exceptionState),
+ info.GetReturnValue().Set(ToV8(result->stringValue(exceptionState),
info.Holder(), info.GetIsolate()));
} else if (result->resultType() == XPathResult::kBooleanType) {
- info.GetReturnValue().Set(toV8(result->booleanValue(exceptionState),
+ info.GetReturnValue().Set(ToV8(result->booleanValue(exceptionState),
info.Holder(), info.GetIsolate()));
} else {
v8::Isolate* isolate = info.GetIsolate();
@@ -452,7 +452,7 @@ void MainThreadDebugger::xpathSelectorCallback(
return;
if (!createDataPropertyInArray(
context, nodes, index++,
- toV8(node, info.Holder(), info.GetIsolate()))
+ ToV8(node, info.Holder(), info.GetIsolate()))
.FromMaybe(false))
return;
}

Powered by Google App Engine
This is Rietveld 408576698