Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)
Patch Set: Rebasing... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 } 322 }
323 323
324 action.setAction(m_data.actions[i].action); 324 action.setAction(m_data.actions[i].action);
325 action.setTitle(m_data.actions[i].title); 325 action.setTitle(m_data.actions[i].title);
326 action.setIcon(m_data.actions[i].icon.string()); 326 action.setIcon(m_data.actions[i].icon.string());
327 action.setPlaceholder(m_data.actions[i].placeholder); 327 action.setPlaceholder(m_data.actions[i].placeholder);
328 328
329 // Both the Action dictionaries themselves and the sequence they'll be 329 // Both the Action dictionaries themselves and the sequence they'll be
330 // returned in are expected to the frozen. This cannot be done with WebIDL. 330 // returned in are expected to the frozen. This cannot be done with WebIDL.
331 actions[i] = 331 actions[i] =
332 freezeV8Object(toV8(action, scriptState), scriptState->isolate()); 332 freezeV8Object(ToV8(action, scriptState), scriptState->isolate());
333 } 333 }
334 334
335 return actions; 335 return actions;
336 } 336 }
337 337
338 String Notification::permissionString( 338 String Notification::permissionString(
339 mojom::blink::PermissionStatus permission) { 339 mojom::blink::PermissionStatus permission) {
340 switch (permission) { 340 switch (permission) {
341 case mojom::blink::PermissionStatus::GRANTED: 341 case mojom::blink::PermissionStatus::GRANTED:
342 return "granted"; 342 return "granted";
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 } 397 }
398 398
399 DEFINE_TRACE(Notification) { 399 DEFINE_TRACE(Notification) {
400 visitor->trace(m_prepareShowMethodRunner); 400 visitor->trace(m_prepareShowMethodRunner);
401 visitor->trace(m_loader); 401 visitor->trace(m_loader);
402 EventTargetWithInlineData::trace(visitor); 402 EventTargetWithInlineData::trace(visitor);
403 ContextLifecycleObserver::trace(visitor); 403 ContextLifecycleObserver::trace(visitor);
404 } 404 }
405 405
406 } // namespace blink 406 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698