third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

index bd4cebc142fc55c0fe694fefba3eabdc33147d26..e56a820eac9a2ec59fd3ea03b4ca03b792eb97ce 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp

@@ -64,8 +64,8 @@ ForeignFetchEvent::ForeignFetchEvent(

m_request = initializer.request();

ScriptState::Scope scope(scriptState);

m_request = initializer.request();

- v8::Local<v8::Value> request = toV8(m_request, scriptState);

- v8::Local<v8::Value> event = toV8(this, scriptState);

+ v8::Local<v8::Value> request = ToV8(m_request, scriptState);

+ v8::Local<v8::Value> event = ToV8(this, scriptState);

if (event.IsEmpty()) {

// |toV8| can return an empty handle when the worker is terminating.

// We don't want the renderer to crash in such cases.