Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)
Patch Set: Rebasing... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
index ec48f15f8c7877705135e302753e0a6f55f74354..f3ce57e001e17e7f934a12f72cb344862e41e28b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
@@ -26,7 +26,7 @@ void testToV8(V8TestingScope* scope,
const char* path,
int lineNumber) {
v8::Local<v8::Value> actual =
- toV8(value, scope->context()->Global(), scope->isolate());
+ ToV8(value, scope->context()->Global(), scope->isolate());
if (actual.IsEmpty()) {
ADD_FAILURE_AT(path, lineNumber) << "toV8 returns an empty value.";
return;
@@ -212,7 +212,7 @@ TEST(ToV8Test, dictionaryVector) {
TEST_TOV8("[object Object]", dictionary);
v8::Local<v8::Context> context = scope.getScriptState()->context();
v8::Local<v8::Object> result =
- toV8(dictionary, context->Global(), scope.isolate())
+ ToV8(dictionary, context->Global(), scope.isolate())
->ToObject(context)
.ToLocalChecked();
v8::Local<v8::Value> one =
@@ -238,7 +238,7 @@ TEST(ToV8Test, withScriptState) {
ScriptValue value(scope.getScriptState(),
v8::Number::New(scope.isolate(), 1234.0));
- v8::Local<v8::Value> actual = toV8(value, scope.getScriptState());
+ v8::Local<v8::Value> actual = ToV8(value, scope.getScriptState());
EXPECT_FALSE(actual.IsEmpty());
double actualAsNumber = actual.As<v8::Number>()->Value();

Powered by Google App Engine
This is Rietveld 408576698