chromeos: Move ownership of system tray width from chrome to ash

chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English

Committed: https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff
Cr-Commit-Position: refs/heads/master@{#427703}

[James Cook, 2016-10-26 00:03:28]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-10-26 00:03:29]

sky, please take a look.

https://codereview.chromium.org/2448373002/diff/1/ash/common/strings/ash_stri...
File ash/common/strings/ash_strings_am.xtb (right):

https://codereview.chromium.org/2448373002/diff/1/ash/common/strings/ash_stri...
ash/common/strings/ash_strings_am.xtb:263: <translation
id="IDS_SYSTEM_TRAY_MENU_BUBBLE_WIDTH_PIXELS">350</translation>
FYI: use_name_for_id in the .grd file makes this work

https://codereview.chromium.org/2448373002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2448373002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:544: ? kMinimumSystemTrayMenuWidthMd
I have email out to tdanderson@ (who is working on material design system tray)
to see if the localized widths need to be adjusted for material design. As far
as I can tell from my casual testing they do not need to change.

[James Cook, 2016-10-26 00:10:35]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-26 00:10:47]

Description was changed from

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider
==========

to

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English
==========

[commit-bot: I haz the power, 2016-10-26 00:11:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:04:23]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-26 02:48:07]

LGTM - the units are actually DIPS, not pixels, but that need not be updated
here.

[James Cook, 2016-10-26 15:18:44]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-26 15:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2448373002/#ps40001
(title: "comment about DIPS")

[commit-bot: I haz the power, 2016-10-26 15:18:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:09:42]

Description was changed from

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English
==========

to

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English
==========

[commit-bot: I haz the power, 2016-10-26 16:09:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 16:15:35]

Description was changed from

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English
==========

to

==========
chromeos: Move ownership of system tray width from chrome to ash

The system tray menu width is customized per locale. Ash should own this
information, not chrome. Move the string that sets the width from
chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd.

This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth()
method so I don't have to refactor it as part of mustash.

BUG=647412
TEST=Run chrome with --lang=de, see system menu get wider than in English

Committed: https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff
Cr-Commit-Position: refs/heads/master@{#427703}
==========

[commit-bot: I haz the power, 2016-10-26 16:15:36]

Patchset 3 (id:??) landed as
https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff
Cr-Commit-Position: refs/heads/master@{#427703}

[James Cook, 2016-11-03 05:05:33]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2468113008/ by jamescook@chromium.org.

The reason for reverting is: This is breaking one of the translation console
tools, see http://crbug.com/660912

We'll need to introduce a new file ash_locale_settings.grd (similar to
ui/strings/app_locale_settings.grd) that the translation console tools can
skip..