Change more base::ListValue methods to use std::unique_ptr.

Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org

Committed: https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255
Cr-Commit-Position: refs/heads/master@{#418494}

[dcheng, 2016-09-13 22:52:54]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[dcheng, 2016-09-13 22:53:04]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[dcheng, 2016-09-13 22:53:05]

Easy ones since they're not used too much.

[commit-bot: I haz the power, 2016-09-13 22:53:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 23:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:12:15]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[danakj, 2016-09-13 23:58:37]

LGTM

https://codereview.chromium.org/2336863003/diff/20001/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/2336863003/diff/20001/base/values.cc#newcode1091
base/values.cc:1091: list_.emplace_back(std::move(in_value));
push back? you have the type going into the list already

https://codereview.chromium.org/2336863003/diff/20001/components/syncable_pre...
File components/syncable_prefs/pref_model_associator.cc (right):

https://codereview.chromium.org/2336863003/diff/20001/components/syncable_pre...
components/syncable_prefs/pref_model_associator.cc:302: for (const auto& value :
from_list_value) {
:)

[dcheng, 2016-09-14 01:16:51]

PTAL, I fixed some CrOS things that I missed the first time too.

https://codereview.chromium.org/2336863003/diff/20001/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/2336863003/diff/20001/base/values.cc#newcode1091
base/values.cc:1091: list_.emplace_back(std::move(in_value));
On 2016/09/13 23:58:37, danakj wrote:
> push back? you have the type going into the list already

Done.

[dcheng, 2016-09-14 01:17:15]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 01:18:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-14 01:55:59]

LGTM

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/users_private/users_private_api.cc
(right):

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:87: for
(const auto& user : users)
{}

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(right):

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:170: for
(const auto& user : users)
{}

also this is a pointer so const auto*?

[dcheng, 2016-09-14 03:06:11]

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/users_private/users_private_api.cc
(right):

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/users_private/users_private_api.cc:87: for
(const auto& user : users)
On 2016/09/14 01:55:59, danakj wrote:
> {}

Done.

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(right):

https://codereview.chromium.org/2336863003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:170: for
(const auto& user : users)
On 2016/09/14 01:55:59, danakj wrote:
> {}
> 
> also this is a pointer so const auto*?

Done, I assumed it a std::unique_ptr but I guess I should have just checked!

[dcheng, 2016-09-14 03:07:04]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-09-14 03:07:04]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2336863003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-09-14 03:07:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 03:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 03:17:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-09-14 05:03:23]

Description was changed from

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
==========

to

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org
==========

[dcheng, 2016-09-14 05:03:23]

dcheng@chromium.org changed reviewers:
+ brettw@chromium.org

[dcheng, 2016-09-14 05:03:36]

TBRing brettw

[dcheng, 2016-09-14 05:03:41]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-14 05:03:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-14 05:13:10]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-14 05:13:11]

/options/ is set noparent, so lgtm for good measure

[commit-bot: I haz the power, 2016-09-14 05:50:17]

Description was changed from

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org
==========

to

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-09-14 05:50:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-14 05:51:47]

Description was changed from

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org
==========

to

==========
Change more base::ListValue methods to use std::unique_ptr.

AppendIfNotPresent() and Insert() now take unique_ptr instead of a raw
pointer.

BUG=581865
TBR=brettw@chromium.org

Committed: https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255
Cr-Commit-Position: refs/heads/master@{#418494}
==========

[commit-bot: I haz the power, 2016-09-14 05:51:48]

Patchset 4 (id:??) landed as
https://crrev.com/66c7a4cb89abd6a94f36c1ef976e08f7f9878255
Cr-Commit-Position: refs/heads/master@{#418494}