Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: extensions/browser/script_executor.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/compositor_util.cc ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/script_executor.cc
diff --git a/extensions/browser/script_executor.cc b/extensions/browser/script_executor.cc
index 230bca3b3f885b2dae5fcfd6731d4402141536af..84fc2c394694cc45b5abf06bd09b6a9a9569102c 100644
--- a/extensions/browser/script_executor.cc
+++ b/extensions/browser/script_executor.cc
@@ -141,9 +141,9 @@ class Handler : public content::WebContentsObserver {
// If this is the main result, we put it at index 0. Otherwise, we just
// append it at the end.
if (is_root_frame && !results_.empty())
- CHECK(results_.Insert(0u, script_value->DeepCopy()));
+ CHECK(results_.Insert(0u, script_value->CreateDeepCopy()));
else
- results_.Append(script_value->DeepCopy());
+ results_.Append(script_value->CreateDeepCopy());
}
if (is_root_frame) { // Only use the root frame's error and url.
« no previous file with comments | « content/browser/gpu/compositor_util.cc ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698