Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2092)

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
index 8ddbcd0bcbf9c345598c36c62882143e79e30ac2..3450f86b9653169bbde4c5e1b582779d61d4538e 100644
--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
@@ -796,8 +796,8 @@ void ChromeUserManagerImpl::SupervisedUserLoggedIn(
// Add the user to the front of the user list.
ListPrefUpdate prefs_users_update(GetLocalState(), kRegularUsers);
- prefs_users_update->Insert(0,
- new base::StringValue(account_id.GetUserEmail()));
+ prefs_users_update->Insert(
+ 0, base::MakeUnique<base::StringValue>(account_id.GetUserEmail()));
users_.insert(users_.begin(), active_user_);
// Now that user is in the list, save display name.
@@ -1237,7 +1237,7 @@ bool ChromeUserManagerImpl::ShouldReportUser(const std::string& user_id) const {
void ChromeUserManagerImpl::AddReportingUser(const AccountId& account_id) {
ListPrefUpdate users_update(GetLocalState(), kReportingUsers);
users_update->AppendIfNotPresent(
- new base::StringValue(account_id.GetUserEmail()));
+ base::MakeUnique<base::StringValue>(account_id.GetUserEmail()));
}
void ChromeUserManagerImpl::RemoveReportingUser(const AccountId& account_id) {

Powered by Google App Engine
This is Rietveld 408576698