chrome/browser/permissions/chooser_context_base.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/chooser_context_base.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/chooser_context_base.cc

diff --git a/chrome/browser/permissions/chooser_context_base.cc b/chrome/browser/permissions/chooser_context_base.cc

index 93125d9990195724fb95a627e996d93c05f689e6..3b99bad21385d39261562354ae5a096ce8d65c9f 100644

--- a/chrome/browser/permissions/chooser_context_base.cc

+++ b/chrome/browser/permissions/chooser_context_base.cc

@@ -115,7 +115,7 @@ void ChooserContextBase::GrantObjectPermission(

object_list = new base::ListValue();

setting->Set(kObjectListKey, object_list);

}

- object_list->AppendIfNotPresent(object.release());

+ object_list->AppendIfNotPresent(std::move(object));

SetWebsiteSetting(requesting_origin, embedding_origin, std::move(setting));

}