components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc ('k') | components/error_page/common/localized_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

index 8011688749fab97da201b55dddcd780135725528..245d75c16c7d1102075227bcc235d04f73a9ca85 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

@@ -8,6 +8,7 @@

#include "base/bind.h"

#include "base/command_line.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string_number_conversions.h"

#include "base/time/time.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h"

@@ -62,9 +63,10 @@ void DataReductionProxySettingsTestBase::SetUp() {

ListPrefUpdate received_update(test_context_->pref_service(),

prefs::kDailyHttpReceivedContentLength);

for (int64_t i = 0; i < kNumDaysInHistory; i++) {

- original_update->Insert(0,

- new base::StringValue(base::Int64ToString(2 * i)));

- received_update->Insert(0, new base::StringValue(base::Int64ToString(i)));

+ original_update->Insert(

+ 0, base::MakeUnique<base::StringValue>(base::Int64ToString(2 * i)));

+ received_update->Insert(

+ 0, base::MakeUnique<base::StringValue>(base::Int64ToString(i)));

}

last_update_time_ = base::Time::Now().LocalMidnight();

pref_service->SetInt64(prefs::kDailyHttpContentLengthLastUpdateDate,